Allow duplicate tags keys

[orZeira]

You disabled the option to set duplicate tags keys (e.g. dog:joe and dog:lisa) in the same record while datadog system support that. Consider replacing your tags container from std::map<std::string, std::string> to std::vector<std::pair<std::string, std::string>>.

[garrettsickles]

Do you have a real world example? I am finding it difficult to think of a time this would happen in the real world. This could help me understand an appropriate way to implement the behavior.

[orZeira]

Yes, for example if i wanted to count the total number of football games this year and be able to see a distribution of how many games each player played. I would do this by record each game to counter metric with the following tags format - 'player:{player name}'.

On Tue, Mar 26, 2019 at 8:57 AM Garrett Frank Sickles < notifications@github.com> wrote:

Do you have an example? I am finding it difficult to think of a time this would happen in the real world. This could help me understand an appropriate way to implement the behavior.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/garrettsickles/DogFood/issues/10#issuecomment-476498850, or mute the thread https://github.com/notifications/unsubscribe-auth/AV-3kd-uQlcN22BN1gUXP0fM6kb_Vo44ks5vacTegaJpZM4cHNBW .

--

[garrettsickles]

Added a pull request - https://github.com/garrettsickles/DogFood/pull/11

Let me know how that looks. Need to add some unit testing around it.

[orZeira]

Looks fine to me 👍