search

garretyoder / Colorful

Android runtime theme library
Apache License 2.0
2.13k stars 193 forks source link

issues #2 #3 #4 #5

Closed meierjan closed 7 years ago

meierjan commented 7 years ago

Please review and tell me what you think

meierjan commented 7 years ago

to address #2 #3 #4

garretyoder commented 7 years ago

These are good changes and I'll merge it if you can remove the .idea folder from your PR. While for a single person adding this folder makes sense, it interferes with file locations (specifically gradle home) whenever anyone else tries to load the project. It's all studio generated setup for the local install.

meierjan commented 7 years ago

I removed the .idea folder.

Yeah I see your poit - although this folder just contains relative paths rather then absolute ones.

https://intellij-support.jetbrains.com/hc/en-us/articles/206544839-How-to-manage-projects-under-Version-Control-Systems

I didn't test my changes too much so please feel free to test again :)

Thanks for the feedback!