[sourceview4] Preliminary support for gtksourceview4

garrigue / lablgtk

LablGTK 2 and 3: an interface to the GIMP Tool Kit

https://garrigue.github.io/lablgtk

Other

89 stars 40 forks source link

[sourceview4] Preliminary support for gtksourceview4 #101

Closed ejgallego closed 7 months ago

ejgallego commented 4 years ago

main changes are in the completion API, see https://developer.gnome.org/gtksourceview/stable/porting-guide-3-to-4.html
todos:
- implement new completion API [present already in sourceview3 but prefixed]
- see what happened with draw_spaces API, restore

Note that CoqIDE was able to get compiled and is functional with the current status of this lib, https://github.com/coq/coq/pull/11412

ppedrot commented 4 years ago

A cursory glance seems to indicate I am not using the modified GtkSourceView completion API in coq/coq#11400.

ejgallego commented 4 years ago

A cursory glance seems to indicate I am not using the modified GtkSourceView completion API in #11400.

You are indeed using the API, but IMHO that's fine, we will rebase after coq/coq#11400 is needed and fix whatever needs to be fixed; in fact the reason this works now is that coqide master is not using the API.

herbelin commented 4 years ago

main changes are in the completion API, see https://developer.gnome.org/gtksourceview/stable/porting-guide-3-to-4.html

So, only the following changes for adapting to the new completion API, right?

gtk_source_completion_show -> gtk_source_completion_start (but not exported in lablgtk3-sourceview3 anyway)
gtk_source_completion_item_new -> split into an eponym function taking no arguments any more and new functions gtk_source_completion_itemset* (the former could be emulated so as to keep the same lablgtk3 API?)
gtk_source_completion_item_new_with_markup, gtk_source_completion_item_new_from_stock -> removed (but a priori emulatable from the new functions)

Sylvain78 commented 1 year ago

A stripped down version of lablgtk3-sourceview3 compiled against gsourceview-4.8.4, leading to a running coqide (on HaikuOS), coqide with gsourceview4 on HaikuOS Though if i play with it , it crashes on calls on _drawspaces functions. Would be glad to see this PR solved to get a polished coqide :)

ejgallego commented 7 months ago

I'm afraid folks I'll have to drop this PR due to lack of cycles. Of course feel free to resume work on it using the code.