garrigue / lablgtk

LablGTK 2 and 3: an interface to the GIMP Tool Kit
https://garrigue.github.io/lablgtk
Other
89 stars 40 forks source link

Linking issues with gcc-10 #112

Closed vprevosto closed 4 years ago

vprevosto commented 4 years ago

I'm unable to compile labgtk3 3.1.0 since I've upgraded my gcc version, with ld reporting multiple definitions of ml_table_extension_events, declared in src/ml_gdk.h on line 89. The symptom looks similar as an issue reported against OCaml itself, and replacing CAMLexport by CAMLextern in the declaration (which technically, without the extern, is a "tentative definition"), as suggested there, indeed fixes the issue.

garrigue commented 4 years ago

Already fixed by #105 Does it mean we need another release?

vprevosto commented 4 years ago

Oops, sorry I didn't see an open issue on the subject, and I didn't check the closed ones 😁. I think that a new release would be good indeed. I initially stumbled upon that by trying to compile the official lablgtk3 package on a new opam switch, and I imagine that this will happen to others, too, especially when 4.11.0 will be out.

garrigue commented 4 years ago

Fixed in 3.1.1.