search

garrigue / lablgtk

LablGTK 2 and 3: an interface to the GIMP Tool Kit
https://garrigue.github.io/lablgtk
Other
89 stars 40 forks source link

[dune] Restore compatibility with dune 2.7.0 #114

Closed voodoos closed 4 years ago

voodoos commented 4 years ago

Dear lablgtk maintainers,

With dune lang 2.7 we plan to check that values in the names field of executables stanza are valid module names. (See PR#3646) Even if the compiler does accepts (with a warning) compilation units whose names are not valid module names.

This PR restore compatibility with dune 2.7.0 by renaming the example/dialog-thread compilation unit.

voodoos commented 4 years ago

@dra27 pointed out the fact that warning 24 was explicitly disabled in the dune file. Does that mean that there is a necessity for the file dialog-thread.ml to be named like that ?

voodoos commented 4 years ago

We might postpone that change to at least dune 3.0 so I am closing this PR.