search

garrigue / lablgtk

LablGTK 2 and 3: an interface to the GIMP Tool Kit
https://garrigue.github.io/lablgtk
Other
89 stars 40 forks source link

dune 2.7.0 says: Error: "dialog-thread" is an invalid module name. #115

Open rwmjones opened 4 years ago

rwmjones commented 4 years ago 
+ dune build -j5
File "examples/dune", line 11, characters 3-16:
11 |    dialog-thread drawing
        ^^^^^^^^^^^^^
Error: "dialog-thread" is an invalid module name.
Module names must be non-empty and composed only of the following characters:
'A'..'Z', 'a'..'z', '_', ''' or '0'..'9'.
Hint: dialog_thread would be a correct module name

Fix is to rename the example.

rwmjones commented 4 years ago

This is the trivial workaround I added to the Fedora package:

+# https://github.com/garrigue/lablgtk/issues/115
+mv examples/dialog-thread.ml examples/dialog_thread.ml
+sed -i -e 's/dialog-thread/dialog_thread/' examples/dune
drew887 commented 4 years ago

It looks like this PR is related https://github.com/garrigue/lablgtk/pull/114 and so the fix is delayed until dune 3? :thinking:

rwmjones commented 4 years ago

I don't know about that, but it's in dune 2.7.0 right now :-) The upstream change seems to have happened in https://github.com/ocaml/dune/commit/92240aaec0e1032dcb8f93904272096b883f50a2