search

garrigue / lablgtk

LablGTK 2 and 3: an interface to the GIMP Tool Kit
https://garrigue.github.io/lablgtk
Other
89 stars 40 forks source link

Deprecated signals in lablgtk3 (expose & set_scroll_adjustments) #124

Closed vrotaru closed 2 years ago

vrotaru commented 3 years ago

The "expose" and "set_scroll_adjustments" signals are deprecated in GTK-3.0 but are still present in lablgtk3

One such place is GText.view class. Another, but related problem is the text view does not have the GtkScrollable interface methods, while the GtkTextView implements the above interface.

My guess is that those methods should be added to GText.view

  method hadjustment : GData.adjustment
  method vadjustment : GData.adjustment

  method set_hadjustment : GData.adjustment -> unit
  method set_vadjustment : GData.adjustment -> unit

A proof of concept patch is here with the usual disclaimer: "Works on my machine"

vrotaru commented 3 years ago

Looks like it was fixed in this PR: https://github.com/garrigue/lablgtk/commit/5cc0f7e389b759beb5af0e1310fa5e230f51845d

So, unless someone intends to do more work on this, like adding scrollable abstract class from which various widget will inherit, this can be closed.