garrigue / lablgtk

LablGTK 2 and 3: an interface to the GIMP Tool Kit
https://garrigue.github.io/lablgtk
Other
89 stars 40 forks source link

Some build fixes #132

Closed talex5 closed 3 years ago

talex5 commented 3 years ago

I'm attempting to get lablgtk3 to build under ocaml-ci. Here are some fixes that seem to help a bit:

Even with this, there are still a lot of errors. e.g.

File "examples/fixed_editor.ml", line 95, characters 28-45:
95 |       let (width, height) = Drawable.get_size w in
                                 ^^^^^^^^^^^^^^^^^
Error: Unbound module Drawable

and

File "examples/image.ml", line 63, characters 2-14:
63 |   Gdk.Rgb.init ();
       ^^^^^^^^^^^^
Error: Unbound module Gdk.Rgb

I'm not sure where these modules are supposed to be coming from. Maybe they were lost in the move to Gtk3?

See https://ci.ocamllabs.io/github/talex5/lablgtk/commit/b387e8446ede079479a23727cfde5ca748e06533 for the full list.

BTW, if you'd like to enable ocaml-ci on the main repository, just go to https://github.com/apps/ocaml-ci/installations/new and add it to (just) this repository. There's no other setup, but I will need to approve the request, so let me know.