search

garrigue / lablgtk

LablGTK 2 and 3: an interface to the GIMP Tool Kit
https://garrigue.github.io/lablgtk
Other
89 stars 40 forks source link

Typo in ml_gtk_text_buffer_get_iter_at_line_index #181

Closed herbelin closed 2 months ago

herbelin commented 2 months ago

Hi, there seems to be a typo in the definition of ml_gtk_text_buffer_get_iter_at_line_index as its code refers to gtk_text_buffer_get_iter_at_line_offset (like in ml_gtk_text_buffer_get_iter_at_line_offset) while I guess gtk_text_buffer_get_iter_at_line_index is instead expected. I did not test the change, but we observed an utf8 issue in coqide which might be caused by this. Best, Hugo

garrigue commented 2 months ago

Indeed, this is a no-brainer. Thanks.

herbelin commented 1 month ago

@garrigue: what are your plans/policy for releases. Is there some chance that a new release including the fix is done before Coq releases its version 8.20, planned end of June?

garrigue commented 1 month ago

I can do that the week of June 10th. Now that OCaml 5.2 is released is a good timing for me too.

herbelin commented 1 month ago

That would be great! Thanks.

garrigue commented 1 month ago

@herbelin I have made a release last week. The opam package (https://github.com/ocaml/opam-repository/pull/26047) is in the pipeline, but I have no idea how long it will take.