search

garrigue / lablgtk

LablGTK 2 and 3: an interface to the GIMP Tool Kit
https://garrigue.github.io/lablgtk
Other
90 stars 40 forks source link

[build] Conflict with Dune 1.7.0 #49

Closed ejgallego closed 5 years ago

ejgallego commented 5 years ago

Bug https://github.com/ocaml/dune/pull/1833 makes our quoting strategy fail; unfortunately it is not easy to fix due to OS-specific issues.

IMHO the issue is not so serious as to warrant an ugly workaround, thus we rather declare a conflict with Dune 1.7.0.

garrigue commented 5 years ago

Here also the MacOS test fails

ejgallego commented 5 years ago

This seems like a Dune 1.7.0 bug c.f: https://github.com/ocaml/dune/issues/1833

Let's see what the maintainers say, if not we'll find a workaround.

ejgallego commented 5 years ago

Indeed this workaround fixed the linux build but broke the OSX one. IMHO Dune should be fixed and this PR not merged.

ejgallego commented 5 years ago

By the way a few tests on Windows builds went pretty OK, but CI on Windows is a bit of a mess still.

ejgallego commented 5 years ago

PR updated.

ejgallego commented 5 years ago

Note that the opam job succeeded, IMHO this can be merged then.

ejgallego commented 5 years ago

I've confirmed that Dune 1.7.1 fixes this issue.

ejgallego commented 5 years ago

CI is fine now.

ejgallego commented 5 years ago

Included in #48