It appears that "make doc" still depends on camlp4

garrigue / lablgtk

LablGTK 2 and 3: an interface to the GIMP Tool Kit

https://garrigue.github.io/lablgtk

Other

89 stars 40 forks source link

It appears that "make doc" still depends on camlp4 #85

Open pmetzger opened 4 years ago

pmetzger commented 4 years ago

Howdy! The following lines seem to be in the Makefile, and they prevent a build on a machine without camlp4 installed.

gtkdoc.cmo : gtkdoc.ml
        $(CAMLC) -I +ocamldoc -pp "$(CAMLP4O) pa_macro.cmo $(ODOC_DEF)" -c $<

garrigue commented 4 years ago

Indeed, there is no way to install the docs without camlp4 or camlp5. Note that you can replace camlp4 by camlp5 if the former is not available for your ocaml version.

pmetzger commented 4 years ago

Ah. I presume removing that as well would be unpleasant? I do note that the package itself no longer depends on camlp4.

ejgallego commented 4 years ago

It think it is very easy to remove the camlp5 dependency on gtkdoc; the if should not apply anymore.

We could even make it run in gtk3 without too much effort [by writing a custom dune rule]

ejgallego commented 4 years ago

See https://github.com/garrigue/lablgtk/pull/96 for a start.