Remove declaration of young_start for ocaml 4.10

garrigue / lablgtk

LablGTK 2 and 3: an interface to the GIMP Tool Kit

https://garrigue.github.io/lablgtk

Other

89 stars 40 forks source link

Closed garrigue closed 4 years ago

garrigue commented 4 years ago

Fix the wrappers.h part of #92 by making the re-declaration of young_start and young_end conditional on ocaml version older than 4.10.
Replace caml_young_{start,end} by young_* in ml_gtktree.c to work around bug in pre-release 4.10.

ejgallego commented 4 years ago

Should a similar PR be done for the gtk3 branch? [I can add Travis support for 4.10]

garrigue commented 4 years ago

Yes, if you see no problem I'll merge it in both branches.

ejgallego commented 4 years ago

Yes, if you see no problem I'll merge it in both branches

If you do a PR for lablgtk3 I can add Travis support for 4.10 so we can see if the fix passes CI.

garrigue commented 4 years ago

Merged this PR, and created a new one the lablgtk3 branch #97