search

garriguv / danger-ruby-swiftformat

A danger plugin to check Swift formatting using SwiftFormat.
MIT License
39 stars 15 forks source link

Add support for inline_mode #45

Closed pahnev closed 1 year ago

pahnev commented 3 years ago

Implements the inline_mode in a similar way it's done in the SwiftLint plugin. SwiftFormat now also supports JSON reporting, which would remove the need to parse the details from the string, but that looks like it would require a lot more changes.

I can also add some tests for this, if you point me to start as I'm not very familiar with how ruby works and have no idea how to access some of the data. E.g. this in danger-swiftLint repo:

PerThomasHaga commented 2 years ago

Need this 👍

pavliuko commented 1 year ago

Any progress here? It would be very nice to have this!

garriguv commented 1 year ago

Thank you for the contribution! I'll merge this and clean up the tests 👍