search

garris / BackstopJS

Catch CSS curve balls.
http://backstopjs.org
MIT License
6.66k stars 602 forks source link

latest: 4.0.6 version: Issues with .setinterceptionEnabled from puppeteer #1047

Open vivekbwaj opened 5 years ago

vivekbwaj commented 5 years ago

I am using setRequestInterception and .respond method from puppeteer. Ever since I updated the package to 4.0.6 the interception stopped working. When chromium encounters this method during test firewall pop-up shows up and then the requests are left pending. I suspect it's got to do something with puppeteer version in backstopjs. With Backstopjs 3.8.8 everything looks good

garris commented 5 years ago

4.0.6 uses latest puppeteer. It is probably a difference with chromium or puppeteer. You may want to look at their docs -- it's possible they changed implementation or behavior.

garris commented 5 years ago

You can use backstop 3.8.8 if needed. That uses older puppeteer.

vivekbwaj commented 5 years ago

I have downgraded to 3.8.8

cdeutsch commented 4 years ago

I've been using puppeteer-request-intercepter which uses page.setRequestInterception(true) with v4.1.12 and it seems to work fine.