search

garris / BackstopJS

Catch CSS curve balls.
http://backstopjs.org
MIT License
6.71k stars 602 forks source link

approve button doesn't update reference image in UI #1194

Open garris opened 4 years ago

garris commented 4 years ago

I am seeing an issue where using approve button doesn't update reference image in the report UI -- however, it does successfully run the approve on the back end -- so this is just a UI issue.

This is most noticeable when you've run backstop for the first time as with the sanity test described here... https://github.com/garris/BackstopJS#sanity-test-does-backstop-work-in-my-environment

Here is what it looked like for me. I expected the reference image column to be updated with the test image... approve does not load approved image or clean up warning

Run this command to try it yourself...

mkdir backstopSanityTest; cd backstopSanityTest; npm install backstopjs; node ./node_modules/backstopjs/cli/ init; node ./node_modules/backstopjs/cli/ remote & node ./node_modules/backstopjs/cli/ test && fg

The above script will create a test directory, install backstop, start a remote process and run a test. Once the test completes it the terminal will bring the remote process to the foreground so you can kill it when you're done testing.

garris commented 4 years ago

@1276stella 👆

@shankarsridhar 👆