search

garris / BackstopJS

Catch CSS curve balls.
http://backstopjs.org
MIT License
6.69k stars 604 forks source link

Bump puppeteer to v12 #1381

Closed mayank99 closed 2 years ago

mayank99 commented 2 years ago

Closes #1373

mayank99 commented 2 years ago

@garris The smoke test is failing because of a small shift in text. This is likely because the rendering logic changed between chromium 93 (last version supported in puppeteer v10) and chromium 97 (latest).

Edit: This was because I'm on Windows. I ran the tests in docker and they all passed 👍 Promoting this PR out of draft

mayank99 commented 2 years ago

Any plans to release this in a new version bump soon?

garris commented 2 years ago

Here you go.. Cheers!

npm notice === Tarball Details ===
npm notice name:          backstopjs
npm notice version:       6.0.2
npm notice package size:  28.9 MB
npm notice unpacked size: 34.4 MB
npm notice shasum:        89da7e817d48defeecd139946b1552eb0155dce0
npm notice integrity:     sha512-oww7tDmeinCrV[...]qkZbpTpRu91Sg==
npm notice total files:   609
npm notice
+ backstopjs@6.0.2
mayank99 commented 2 years ago

@garris Just tested 6.0.2 and while it works, I noticed that if I run with --docker, it's still using 6.0.1 so it doesn't get pupeeteer 12.

I am not sure if it means anything but I noticed that the SHA digest on DockerHub is same for both 6.0.1 and 6.0.2. https://hub.docker.com/r/backstopjs/backstopjs/tags

If it's not an easy fix, I can create a new issue to track this.

garris commented 2 years ago

@mayank99 Oh crap. Thanks for the heads up. Let me see if I can get this thing to properly bump.

garris commented 2 years ago

@mayank99 OK. It was a bad deploy. Should be good now! Please validate when you get the chance. Cheers!

mayank99 commented 2 years ago

Can confirm 6.0.4 is working with the docker image. Thanks!