search

garris / BackstopJS

Catch CSS curve balls.
http://backstopjs.org
MIT License
6.69k stars 604 forks source link

Update to latest node LTS: 16.14.0 #1395

Closed anthony-hull closed 2 years ago

anthony-hull commented 2 years ago

I built this locally and my project's tests still run using the built image after the upgrade. Is there any other testing you would want doing on this?

It does include an upgrade to a new version of Debian as the node 16 image uses a new major release .

garris commented 2 years ago

Thank you!

fuhlig commented 2 years ago

Additionally to the node update there was this change: https://github.com/anthony-hull/BackstopJS/blob/1dea8826051fc0254ce75d3c8039f321dd90dda7/docker/Dockerfile#L32

@anthony-hull Could you please add details what / why this change was made? Was not able to retrace it in the commit Thanks in advance :)

anthony-hull commented 2 years ago

The upgrade to Debian Buster via moving to the new node image has this missing as a dependancy for puppeteer. Once I added this it worked again.

anthony-hull commented 2 years ago

https://github.com/puppeteer/puppeteer/issues/5661 I think it was the same error as this

fuhlig commented 2 years ago

Thanks for clarifying 👍