garris / BackstopJS

Catch CSS curve balls.
http://backstopjs.org
MIT License
6.67k stars 605 forks source link

Remove usage of deprecated/removed waitFor in clickAndHoverHelper scripts #1441

Closed flosell closed 1 year ago

flosell commented 1 year ago

Puppeteer deprecated and by now, removed page.waitFor() (see puppeteer/puppeteer#6214). This results in TypeError: page.waitFor is not a function when using things like postInteractionWait, clickSelector and similar features relying on clickAndHoverHelper.js. See #1431 for details.

You can observe this issue when running npm run smoke-test:

Screenshot 2022-10-09 at 12 31 02

This PR fixes all usage of waitFor in examples, tests and templates used for backstop init.

Projects that ran backstop init would still need to change their version of the scripts themselves but at least for new usages, this issue would be fixed (and existing users would have a guide what a fixed version would look like)

(by the way, it's Hacktoberfest so consider opting in by adding a hacktoberfest topic to the repo before merging PRs to give contributors a chance for a tiny reward 😄 )

garris commented 1 year ago

This is great. Thank you!