garris / BackstopJS

Catch CSS curve balls.
http://backstopjs.org
MIT License
6.67k stars 605 forks source link

Remote Service #1446

Closed Merynek closed 1 year ago

Merynek commented 1 year ago

I tried Remote service but immediately after this command: backstop remote it display image and on http://127.0.0.1:1234/ i cant see anything naturally.

Any idea?

martiniert commented 1 year ago

Same problem here using BACKSTOP_REMOTE_HTTP_PORT=3001 backstop remote or backstop remote

Merynek commented 1 year ago

Same problem here using BACKSTOP_REMOTE_HTTP_PORT=3001 backstop remote or backstop remote

Totally same :-) I run backstop remote

martiniert commented 1 year ago

@Merynek it seems to be working with 6.1.3, fyi

garris commented 1 year ago

Uh oh. Looks like this is broken in 6.1.4. I will roll this back.

dgrebb commented 1 year ago

Was this fixed? I haven't been able to get remote working with Node 16, 18, on any port I can think of.

What's happening

@6.2.2

❯ BACKSTOP_REMOTE_HTTP_PORT=1338 backstop remote --config="backstop.production.json"
BackstopJS v6.2.2
Loading config:  /Users/dgrebb/Projects/backstop/_ci/backstop/backstop.production.json

COMMAND | Executing core for "remote"
 remote | Starting remote with: node /Users/dgrebb/.nvm/versions/node/v16.18.1/lib/node_modules/backstopjs/node_modules/super-simple-web-server/index.js /Users/dgrebb/Projects/backstop/_ci/backstop /Users/dgrebb/.nvm/versions/node/v16.18.1/lib/node_modules/backstopjs/remote --config=/Users/dgrebb/Projects/backstop/_ci/backstop/backstop.production.json with env {"SSWS_HTTP_PORT":"1338"}
 remote | Backstop remote connection closed.
COMMAND | Command "remote" successfully executed in [0.006s]

@6.1.3

image

image

BACKSTOP_REMOTE_HTTP_PORT=1338 backstop remote --config="backstop.production.json"
BackstopJS v6.1.3
Loading config:  /Users/dgrebb/Projects/backstop/_ci/backstop/backstop.production.json

COMMAND | Executing core for "remote"
 remote | Starting remote with: SSWS_HTTP_PORT=1338 node /Users/dgrebb/.nvm/versions/node/v16.18.1/lib/node_modules/backstopjs/node_modules/super-simple-web-server/index.js /Users/dgrebb/Projects/backstop/_ci/backstop /Users/dgrebb/.nvm/versions/node/v16.18.1/lib/node_modules/backstopjs/remote --config=/Users/dgrebb/Projects/backstop/_ci/backstop/backstop.production.json
 remote |
          ---------------

 remote | Starting static hosts with root: /Users/dgrebb/Projects/backstop/_ci/backstop
          Press Ctrl + C to exit.
          ---------------

 remote | Listening on: http://127.0.0.1:1338

 remote | Listening on: https://127.0.0.1:3001

 remote | Request from:  /

 remote | Request from:  /

What I've Tried

Side Notes

dgrebb commented 1 year ago

@garris @Merynek @martiniert submitted a PR for the fix: https://github.com/garris/BackstopJS/pull/1488

garris commented 1 year ago

@dgrebb Thanks for this!

yuany2036 commented 9 months ago

Hey guys, this problems seems to have persisted to some degree, have tried using the remote command with no success, running on version 6.2.2 on macOS Sonoma. Running it with the command BACKSTOP_REMOTE_HTTP_PORT=8080 backstop remote --config="backstop.config.js" results in the same error message:

I tried Remote service but immediately after this command: backstop remote it display image and on http://127.0.0.1:1234/ i cant see anything naturally.

Any idea?

Was able to get it running when switching over to version 6.1.3, though no button appears for approving in the web interface. It also runs on my colleagues Windows system, though had to remove the port definition for it to work. This problem is encountered by someone else as well, as can be seen in this issue: https://github.com/garris/BackstopJS/issues/1498 Please let me know if there is any other information I could provide to help troubleshoot this, thanks!