Rollback docker user change

garris / BackstopJS

Catch CSS curve balls.

http://backstopjs.org

MIT License

6.66k stars 602 forks source link

Rollback docker user change #1476

Closed tkrah closed 1 year ago

tkrah commented 1 year ago

defaults to root now again
added a recommendation to the README.md to configure a more appropriate user to run the test by changing the dockerCommandTemplate config option
fixes (#1466)

tkrah commented 1 year ago

@garris That would be my proposal like discussed - nothing better came to my mind to honor your expectations ;-)

neclimdul commented 1 year ago

@garris this looks like the fix to something I was running into but it doesn't seem to have made its way into a tagged release on over to docker hub. any changes you could do that?

garris commented 1 year ago

Will look at this today

garris commented 1 year ago

Yup -- looks like the last publish clearly didn't work. Just pushed a new version please LMK if it's not working as expected.

Cheers.

neclimdul commented 1 year ago

Looks great! Thanks!