search

garris / BackstopJS

Catch CSS curve balls.
http://backstopjs.org
MIT License
6.66k stars 602 forks source link

potential fix for puppet warning #1486

Open Neychok opened 1 year ago

Neychok commented 1 year ago

Would something like this fix https://github.com/garris/BackstopJS/issues/1485 ?

I've never contributed to BackstopJS before so I am sorry if I missed any steps when creating this PR.

Happy to work on this more, if any other changes are required.

tkrah commented 1 year ago

You would need to pass the string "new" to fix that warning - but I can't recommend using new yet, see the issue comment.

dgrebb commented 7 months ago

Thanks for the work on this @Neychok — I submitted a new PR which will work with backwards compatibility in mind.