Headless mode: deprecation warning after upgrading

garris / BackstopJS

Catch CSS curve balls.

http://backstopjs.org

MIT License

6.66k stars 602 forks source link

Headless mode: deprecation warning after upgrading #1525

Closed fuhlig closed 6 months ago

fuhlig commented 6 months ago

After the upgraded Puppeteer dependency with the latest 6.3.1 release, Puppeteer/Chrome throws the following deprecation warning:

docs: https://developer.chrome.com/docs/chromium/new-headless?hl=en

While this is documented in the Backstop docs, it might be a better option is setting the headless mode to new by default to avoid deprecation warnings (and potential failures in future versions).

dgrebb commented 6 months ago

@fuhlig I agree, and know this is planned for a future release. "new" is not new so much anymore ¯_(ツ)_/¯

I'll look into submitting a PR for the change today.

fuhlig commented 6 months ago

Cheers mate

dgrebb commented 6 months ago

@fuhlig I just remembered to follow up! This can probably be closed — check out #1535 and backstop@latest (6.3.3).

There are some notes in the PR about Playwright to be aware of. We didn't think it was a good idea to default that runner to 'new' just yet.

Happy new year!

fuhlig commented 6 months ago

Awesome, thanks @dgrebb! Will check it out next week

Have a happy new year!