search

garris / BackstopJS

Catch CSS curve balls.
http://backstopjs.org
MIT License
6.71k stars 603 forks source link

fix: use `github.event.pull_request.head.sha` for checkout@v4 #1531

Closed dgrebb closed 9 months ago

dgrebb commented 9 months ago

@garris trying something else for the failing GH actions — I recently updated the checkout action to v4, and see that one of their examples uses head.sha instead of head.ref.

Can we please give this a try?

dgrebb commented 9 months ago

🙈 Backstop & Docker CI

@garris this badge and the passed Checks on this PR confirm the fix 👍

garris commented 9 months ago

It works! Amazing! 🌈

garris commented 9 months ago

Oof -- merge blocker.

image

garris commented 9 months ago

I can probably brute-force this tomorrow.

dgrebb commented 9 months ago

@garris I've never seen this GitHub UI before — what's the context? Did it pop up when clicking squash merge?

dgrebb commented 9 months ago

I added actions: write permission to the workflows. Let's see what that does?

garris commented 9 months ago

Worked!