dependency updates, node 20, and backstopjs@6.3.0 support - Githubissues

garris / ember-backstop

BackstopJS visual regression testing addon for Ember.

MIT License

56 stars 21 forks source link

dependency updates, node 20, and backstopjs@6.3.0 support #87

Closed dgrebb closed 7 months ago

dgrebb commented 10 months ago

Summary

This is a general refresh PR, which sets the project up for Node 20 support in a forthcoming BackstopJS release.

Details

configure .eslintrc.js to use ecmaVersion: 2020
general eslint formatting adjustments with the latest rules
- adds eslint-disable where necessary
updates addon-test-support/index.js export — this was not working with ember-cli@^5.4.0, or perhaps @ember-test-helpers@^3.2.0
specify "type": "commonjs" in package.json
update all the things

General Testing Performed

✓ ember install ember-backstop
✓ ember generate acceptance-test home-test
File: tests/acceptance/home-test.js Line 3: import backstop from 'ember-backstop/test-support/backstop';

File: tests/acceptance/home-test.js

15:   test('it renders the thing', async function (assert) {
16:     await visit('/');
17:     await backstop(assert);
18:     assert.dom('#ember-welcome-page-id-selector').exists();
19:   });

✓ ember serve
✓ ember backstop-remote
✓ ember test
✓ verified running tests/screen shots in:
- http://localhost:4200/tests
- http://localhost:3000/backstop_data/html_report/index.html
✓ ember backstop-stop

dgrebb commented 9 months ago

@garris with the publish of backstopjs@6.3.0 to npm (and Docker), this is ready to go as well!

Please let me know if you have any questions.