search

garritfra / darktheme.club

A collection of web pages from across the Internet. To qualify, your website must either use a dark theme by default, or respect the preference of the user.
https://darktheme.club
MIT License
33 stars 80 forks source link

revuo-xmr.com question #160

Closed rottenwheel closed 5 months ago

rottenwheel commented 5 months ago

The website's light/dark theme toggle and theme no longer need JavaScript to function, it was all modified to work with CSS/HTML. Since it is not JavaScript anymore, but it also is not mediaquery, would there be a third method to list it as on darktheme.club?

Can fact check by visiting the website with javascript disabled if need be, Tor browser with strict secure settings, or what have you.

Related: https://github.com/rottenwheel/revuo-weekly/commit/ffa3d1aacf30c1217d3ee826cde943950006861d

garritfra commented 5 months ago

The button still uses an event listener through js to toggle a class, so I'd argue that the site still falls into the "javascript" category. :)

The PR you linked is just moving a lot of things from JS to CSS, which is great, but the main - mechanism is still JS (also no shame in that, it's arguably good to give the user the option to switch the theme).