Fix for TextBoxes and OpenGLSample crash - Githubissues

garrynewman / GWEN

Abandoned: GWEN - GUI Without Extravagant Nonsense.

MIT License

429 stars 102 forks source link

Fix for TextBoxes and OpenGLSample crash #27

Closed DeeKayHT closed 11 years ago

DeeKayHT commented 11 years ago

TextBox Fix:

When moving the caret or adding characters that exceed the textbox's visible space, the text did not change its position, although the carat did.
Adds empty PostLayout() in TextBox class to avoid Label's PostLayout from being called. Otherwise the text's position will always be set to a fixed position defined by the alignment.

OpenGLSample Crash Fix:

Order of operations was causing the crash. The OpenGL renderer was being deleted before the TexturedBase skin, which depended on it.
Changes TexturedBase skin to a pointer, allowing it to be deleted before the OpenGL renderer.

Misc changes:

Removed extraneous semicolon in TextBox::MakeCaratVisible()
Added newline in TextBox.cpp and OpenGLSample.cpp to avoid GNU compiler warnings

DeeKayHT commented 11 years ago

Closing pull request to make multiple pull requests specific to each fix. Apologies, this is my first time using git/GitHub.