Can't perform a React state update on an unmounted component

garthenweb / react-stickup

React components to stick elements at the top of the page while scrolling

http://garthenweb.github.io/react-stickup

MIT License

24 stars 4 forks source link

Can't perform a React state update on an unmounted component #29

Closed anetecima closed 3 years ago

anetecima commented 4 years ago

subscriptions and asynchronous tasks should be canceled on unmount Screenshot_20200903_115607

garthenweb commented 3 years ago

@anetecima Thanks for the report, this should be fixed now in v1.12.0. Feel free to check it out!

anetecima commented 3 years ago

@garthenweb I use your slider in a project I work with on a daily basis. I have to say, I've done large research on available sticky components and this one is the most flexible and covers a lot of nontrivial cases.

The project I have is a SPA and I always get this when changing pages, even with the fix that was added. Screenshot (180)

I really hope it's possible to fix this issue somehow. Thanks a lot for the work you are doing here!