garthenweb / react-stickup

React components to stick elements at the top of the page while scrolling
http://garthenweb.github.io/react-stickup
MIT License
24 stars 4 forks source link

fix(stickup): fixes crashes in Suspense environment #48

Open chin2km opened 1 month ago

chin2km commented 1 month ago

This PR:

garthenweb commented 1 month ago

This PR adds a bit of complexity to the stickup library as it makes many things optional. Technically the contract was that the react-viewport-utils should not call layout functions if no element is defined. Can we move this logic completely to react-viewport-utils?