search

garu / App-cpanminus-reporter

stand-alone CPAN Testers client (for cpanminus and friends)
13 stars 13 forks source link

Allow parsing of reports where URI scheme is 'file'. #29

Closed jkeenan closed 1 year ago

jkeenan commented 7 years ago

This permits a user to file CPANtesters reports where 'cpanm' has been targeted to a file on disk -- typically, a file in a minicpan repository.

Add a build.log in which the user targeted a minicpan tarball and in which 'cpanm' identified an uninstalled prerequisite for which it went out to CPAN. Thus, this build.log demonstrates use of both the 'file' and 'http" schemes. Use this log as the basis for a new test file, with mocking sub modified appropriately.

Add 2 entries to MANIFEST.SKIP and re-make manifest.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.6%) to 91.68% when pulling 46d2a5dc11ec025c0daaaed891f573f5ac4f9346 on jkeenan:allow-file-scheme-20171201 into 50bde41e743206e3a7e79796f917699663e4c19b on garu:master.

jkeenan commented 6 years ago

Garu, one of the dummy data files I used in testing and which is listed in the MANIFEST, t/data/Phony-PASS-0.01.tar.gz, appears to have gone missing. Please put this pull request on hold until I can reconstitute it. Thanks.

jkeenan commented 6 years ago

I think I've located the missing fixture. I'll try to repair the pull request later today. Thanks.

jkeenan commented 6 years ago

Garu, the problem appeared to be meta-bureaucratic. Your .gitignore has an entry for *.tar.gz. In my branch, I added a dummy file for testing the file schema named t/data/Phony-PASS-0.01.tar.gz. So when you or I called git clean, boom went that file without a trace!

As a workaround, I renamed the dummy file to end in .tgz. All tests now PASS for me locally.

Note that your .travis.yml file only requests testing against two perls: 5.20 and 5.8. You request coverage analysis in both versions, but it appears that travis cannot handle that for 5.8. In both my github account and (for the p.r.) yours, the build for 5.8 fails like this:

The command "PERL5OPT=-MDevel::Cover=-coverage,statement,branch,condition,path,subroutine prove -lrsv t" exited with 255.
0.04s$ cover
Global symbol "$Options" requires explicit package name at /home/travis/perl5/perlbrew/perls/5.8/bin/cover line 23.
Global symbol "%Config" requires explicit package name at /home/travis/perl5/perlbrew/perls/5.8/bin/cover line 23.
Global symbol "%Config" requires explicit package name at /home/travis/perl5/perlbrew/perls/5.8/bin/cover line 23.
BEGIN not safe after errors--compilation aborted at /home/travis/perl5/perlbrew/perls/5.8/bin/cover line 57.
The command "cover" exited with 255.

See, e.g., https://travis-ci.org/jkeenan/App-cpanminus-reporter/jobs/369607344

Personally, while I'm a huge Devel::Cover fan, I simply run cover locally. I don't depend on Travis to do it for me. You might want to rework .travis.yml to deal with this problem and also to request more recent perls.

Thank you very much. Jim Keenan

jkeenan commented 6 years ago

Garu, the problem appeared to be meta-bureaucratic. Your .gitignore has an entry for *.tar.gz. In my branch, I added a dummy file for testing the file schema named t/data/Phony-PASS-0.01.tar.gz. So when you or I called git clean, boom went that file without a trace!

As a workaround, I renamed the dummy file to end in .tgz. All tests now PASS for me locally.

Note that your .travis.yml file only requests testing against two perls: 5.20 and 5.8. You request coverage analysis in both versions, but it appears that travis cannot handle that for 5.8. In both my github account and (for the p.r.) yours, the build for 5.8 fails like this:

The command "PERL5OPT=-MDevel::Cover=-coverage,statement,branch,condition,path,subroutine prove -lrsv t" exited with 255.
0.04s$ cover
Global symbol "$Options" requires explicit package name at /home/travis/perl5/perlbrew/perls/5.8/bin/cover line 23.
Global symbol "%Config" requires explicit package name at /home/travis/perl5/perlbrew/perls/5.8/bin/cover line 23.
Global symbol "%Config" requires explicit package name at /home/travis/perl5/perlbrew/perls/5.8/bin/cover line 23.
BEGIN not safe after errors--compilation aborted at /home/travis/perl5/perlbrew/perls/5.8/bin/cover line 57.
The command "cover" exited with 255.

See, e.g., https://travis-ci.org/jkeenan/App-cpanminus-reporter/jobs/369607344

Personally, while I'm a huge Devel::Cover fan, I simply run cover locally. I don't depend on Travis to do it for me. You might want to rework .travis.yml to deal with this problem and also to request more recent perls.

Thank you very much. Jim Keenan

garu commented 1 year ago

Hi Jim! Thank you so much for this patch and all the effort you put in it, and sorry for taking so long. I've just merged it, but I'm going to try and tweak it a bit to prevent the empty "author" field when the resource is a file, since I think this field is rather important for the cpantesters backend. Thanks again!