clone mg_ptr for magic - Githubissues

atoomic commented 5 years ago

Handle mg_ptr to avoid to share it with other PVs.

coveralls commented 5 years ago

Coverage remained the same at 100.0% when pulling ea428d1f56d813d5048de442774eab1bff758e9a on atoomic:magic into 623c600717444acbb0bf64184311f6f1b7e929cb on garu:master.

garu commented 5 years ago

@HaraldJoerg Thank you for reporting! @atoomic Thank you for fixing!

Clone 0.42 should hit your friendly CPAN mirror any moment now :)

garu commented 5 years ago

Hey @atoomic! Looks like we broke Geo::Address::Formatter 😱

https://rt.cpan.org/Ticket/Display.html?id=130195

Could you maybe take a look and see if we can fix it? If you have the time, of course!

atoomic commented 5 years ago

interesting, I will have a look at this thanks for the update

On Mon, Jul 29, 2019 at 12:59 PM Breno G. de Oliveira < notifications@github.com> wrote:

Hey @atoomic https://github.com/atoomic! Looks like we broke Geo::Address::Formatter 😱

https://rt.cpan.org/Ticket/Display.html?id=130195

Could you maybe take a look and see if we can fix it? If you have the time, of course!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/garu/Clone/pull/25?email_source=notifications&email_token=AADC6IQ2IJGN7AKBI5ZAUVTQB44XJA5CNFSM4IEKEY32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3BVYSI#issuecomment-516119625, or mute the thread https://github.com/notifications/unsubscribe-auth/AADC6IR4DKHRG4SX3V3T2CLQB44XJANCNFSM4IEKEY3Q .

atoomic commented 5 years ago

This is going to be fixed via https://github.com/garu/Clone/pull/26 Not sure if I can do a release of it, @garu can you review and publish a release?

thanks nicolas

On Mon, Jul 29, 2019 at 12:59 PM Breno G. de Oliveira < notifications@github.com> wrote:

Hey @atoomic https://github.com/atoomic! Looks like we broke Geo::Address::Formatter 😱

https://rt.cpan.org/Ticket/Display.html?id=130195

Could you maybe take a look and see if we can fix it? If you have the time, of course!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/garu/Clone/pull/25?email_source=notifications&email_token=AADC6IQ2IJGN7AKBI5ZAUVTQB44XJA5CNFSM4IEKEY32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3BVYSI#issuecomment-516119625, or mute the thread https://github.com/notifications/unsubscribe-auth/AADC6IR4DKHRG4SX3V3T2CLQB44XJANCNFSM4IEKEY3Q .

HaraldJoerg commented 5 years ago

While you're at it: I stumbled over another segfault problem when a structure happened to contain a DBI database handle. On Linux, the demo attached dies with Clone 0.41 and Clone 0.42, while it seems to work on Windows.

Cloning database handles is, of course, veeery suspicious (and should not have happened in my code in the first place), but some sort of safeguarding in Clone would be nice. dbhclone.txt

atoomic commented 5 years ago

Any chance you could report that as a GitHub ticket, with what would be nice a simple script to reproduce the error?

Any chance this is related to https://github.com/garu/Clone/issues/17

thanks in advance nicolas

On Mon, Jul 29, 2019 at 1:36 PM Harald Jörg notifications@github.com wrote:

While you're at it: I stumbled over another segfault problem when a structure happened to contain a DBI database handle. On Linux, the demo attached dies with Clone 0.41 and Clone 0.42, while it seems to work on Windows.

Cloning database handles is, of course, veeery suspicious (and should not have happened in my code in the first place), but some sort of safeguarding in Clone would be nice. dbhclone.txt https://github.com/garu/Clone/files/3444009/dbhclone.txt

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/garu/Clone/pull/25?email_source=notifications&email_token=AADC6IXBXC2U7LY6UAIWDQLQB5BCPA5CNFSM4IEKEY32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3BY2GQ#issuecomment-516132122, or mute the thread https://github.com/notifications/unsubscribe-auth/AADC6ISOHQUTNQECPZD3TGTQB5BCPANCNFSM4IEKEY3Q .

HaraldJoerg commented 5 years ago

Sure, will report an issue. The relation to #17 is probably just what's given there as a root cause: "Database handles can't be cloned".

atoomic commented 5 years ago

ok I realized I've permissions to publish Clone, I've just uploaded an updated version of Clone 0.43 to CPAN, it should be available in the next minutes.

Please confirm that this is fixing your issue.

sincerely nicolas

On Mon, Jul 29, 2019 at 1:35 PM Nicolas R. atoomic@cpan.org wrote:

This is going to be fixed via https://github.com/garu/Clone/pull/26 Not sure if I can do a release of it, @garu can you review and publish a release?

thanks nicolas

On Mon, Jul 29, 2019 at 12:59 PM Breno G. de Oliveira < notifications@github.com> wrote:

Hey @atoomic https://github.com/atoomic! Looks like we broke Geo::Address::Formatter 😱

https://rt.cpan.org/Ticket/Display.html?id=130195

Could you maybe take a look and see if we can fix it? If you have the time, of course!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/garu/Clone/pull/25?email_source=notifications&email_token=AADC6IQ2IJGN7AKBI5ZAUVTQB44XJA5CNFSM4IEKEY32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3BVYSI#issuecomment-516119625, or mute the thread https://github.com/notifications/unsubscribe-auth/AADC6IR4DKHRG4SX3V3T2CLQB44XJANCNFSM4IEKEY3Q .

garu / Clone

clone mg_ptr for magic #25