Closed garubi closed 5 years ago
after some testing issue #22 seems to be solved the default values are set ok but the preset change leds are wrong
Needs further work on preset change before we could consider for merging
the defaults values have to be set accordingly the SEND_BOTH and IS_GLOBAL settings or they could be overwrote. But since SEND_BOTH and IS_GLOBAL are preset_dependently we shoult set the default values at the presete levele (in the PRESETS array)
the defaults values have to be set accordingly the SEND_BOTH and IS_GLOBAL settings or they could be overwrote. But since SEND_BOTH and IS_GLOBAL are preset_dependently we shoult set the default values at the presete levele (in the PRESETS array)
Not really. With the fix of issue #35 there's no overwriting, it just respect the behaviour set for that buttons in the PRESETS array. But anyway it would be very logic to set the defaults at Preset level
Please test if:
issue #29 (default values) is fixed
issue #22 (not react to first-push after status change) is addressed
no regression was introduced in ather operations
If it's ok merge and keep building on this