garutilorenzo / k3s-oci-cluster

Deploy a Kubernetes cluster for free, using k3s and Oracle always free resources
https://garutilorenzo.github.io/deploy-kubernetes-for-free-oracle-cloud
GNU General Public License v3.0
225 stars 79 forks source link

Add support for Oracle Linux instances and OCI CCM #16

Closed Djelibeybi closed 2 years ago

Djelibeybi commented 2 years ago

This PR refactors some of the resources to create a k3s_primary_server which is then used to optionally deploy the OCI Cloud Controller Manager to the cluster. This is disabled by default.

A terraform.tfvars.sample is provided in the example/ folder to explain some of the new/changed/removed variables.

Signed-off-by: Avi Miller avi.miller@oracle.com

Djelibeybi commented 2 years ago

FYI, I forgot to add the new variables to the table in README.md

garutilorenzo commented 2 years ago

Wow that's a lot of new features 👍 I think I will split this PR in two sub PR:

Please don't delete your branch so I can create the new feature branches. Stupid question: the OCI Cloud Controller Manager is compatible with Ubuntu right?

Djelibeybi commented 2 years ago

Good call. :)

OCI CCM should work on both distros, but I don't think I've tested it on Ubuntu on Arm. If it doesn't, I'll raise that with the CCM team.

garutilorenzo commented 2 years ago

Are this file missing in your branch?

Djelibeybi commented 2 years ago

No, they're embedded in k3s-server-install.sh because it was easier than trying to ship them with Terraform.

garutilorenzo commented 2 years ago

This resource "null_resource" "oci_ccm_config" is required?

Djelibeybi commented 2 years ago

Nope, that's embedded too. I was playing with a bunch of things, and must've forgotten to remove those. I've just found another issue I hadn't considered (the case when expose_kubeapi is true) so give me a couple of days to fix this and clean the rest up.

mannp commented 2 years ago

Nope, that's embedded too. I was playing with a bunch of things, and must've forgotten to remove those. I've just found another issue I hadn't considered (the case when expose_kubeapi is true) so give me a couple of days to fix this and clean the rest up.

Hey @Djelibeybi @garutilorenzo, wondered if OCI CCM ever got calved out and implemented?

garutilorenzo commented 2 years ago

Hi @mannp CCM is in roadmap. I will open a new PR ASAP

mannp commented 2 years ago

Hi @mannp CCM is in roadmap. I will open a new PR ASAP

HI @garutilorenzo thanks for clarifying, appreciated.