search

garvins / php-git

PHP bindings for libgit2
http://libgit2.github.com
MIT License
60 stars 10 forks source link

Any help required? #6

Open phpengine opened 7 years ago

phpengine commented 7 years ago

Hi there Garvin,

I'd like to contribute to this. I have good PHP knowledge but very little C. If there's anything I can help with - CI, Testing, Infra or PHP, I can.

Thanks

garvins commented 7 years ago

Hi David,

oh that sounds good. Working on CI and Testing would be a real help. Do you know how to test an Extension?

Thanks

phpengine commented 7 years ago

Hi Garvin,

I've not done it before for a php extension, but I've written lots of unit and functional tests for php applications, and can definitely get it into a build, probably with a public report page link.

I've just looked it up on http://qa.php.net/ ,PHP themselves appear to have been using http://ci.qa.php.net/ until 9 months ago, and are now using http://gcov.php.net/viewer.php?version=PHP_7_1&func=tested_functions which I guess automatically updates.

I've been looking at the syntax of .phpt files such as below... https://github.com/php/php-src/blob/master/tests/basic/006.phpt

These seem simple to write, I'm sure I can get plenty of these done. Functional tests with an expect clause seem very reasonable to grasp.

I was thinking I'll make a fork, and fire up a build server, put the configs into the repo, make a simple starter test or two, to get it running from a webhook/poll?

Does that sound about right? (Hopefully)

Thanks

garvins commented 7 years ago

Hi David,

I am sorry for my late response, had a lot of trouble last weeks. Like you say it should be reasonable to write good phpt-tests, if you are skilled in unit testing.

What you are writing about the setup sounds great to me. Tell me as soon you are ready to integrate it into this repository.

Thanks

phpengine commented 7 years ago

Great!

No problemo for a late response, I've gotten a few bits ready hoping for that answer, so I'll post them in later.... Then you can have a look, give some feedback and the like, and I'll start making Pull Requests.

Thanks Garvin