search

gary-kim / riotchat

Element for Nextcloud
https://apps.nextcloud.com/apps/riotchat
GNU Affero General Public License v3.0
123 stars 21 forks source link

OIDC not allowed to load /_synapse/client/oidc/callback as iframe #591

Closed verymilan closed 3 months ago

verymilan commented 3 months ago

Hi there, i have seen that https://github.com/gary-kim/riotchat/pull/80 exists and am wondering if i am getting this wrong... /_synapse/client/oidc/callback sets X-Frame-Options: DENY and frame-ancestors 'none';. I have tried to modify these for the Matrix proxy without success (I was only able to add to these which messes with the syntax at least for ancestors, or to have duplicates).

Is it really something that could be controlled like with the references pullrequest? Or is it perhaps possible to go through the SSO routine using a different tab vs the iframe?

gary-kim commented 3 months ago

It should redirect you to a non-iframed version when you try to login using SSO (I also use OIDC on my Synapse homeserver). I'm not in front of my system right now but I will attempt to reproduce this once I am.

gary-kim commented 3 months ago

Could you provide more information about how you get to the login page and your configuration? I am unable to reproduce this right now, the automatic redirect is opening the page in a new tab when attempting to login with SSO.

verymilan commented 3 months ago

Oh no, I am so sorry, this is not a deployment done by me and it turns out they are using the "External sites" plugin instead. I wasn't expecting this so I didn't check. So sorry for the noise! And thank you for the swift reply!