gary-rowe / hid4java

A cross-platform Java Native Access (JNA) wrapper for the libusb/hidapi library. Works out of the box on Windows/Mac/Linux.
MIT License
223 stars 70 forks source link

./build-hidapi.sh: line 237: syntax error near unexpected token `(' #114

Closed tresf closed 2 years ago

tresf commented 3 years ago

Testing ./build-hidapi.sh on the issue-93 branch, bash seems to get hung-up on the (ARMv8) portions of the script. Removing the parentheses seems to fix this.

I'm working to add arm64 support to this branch, so I'll fix this bug as a part of the Pull Request.

The fix is:

https://github.com/gary-rowe/hid4java/blob/b1c3a6dcd7e33ee818ebcdb827ab92d4ca28de53/build-hidapi.sh#L206

-    echo -e "\033[32mBuilding ARM64/aarch64 (ARMv8)\033[0m"
+    echo -e "\033[32mBuilding ARM64/aarch64 ARMv8\033[0m"

I assume this script is still actively used, so I'm not entirely sure why it's broken on only my machine, but I wanted to document this as it may get lost in the PR.

tresf commented 2 years ago

Closed via #115