search

gary-rowe / hid4java

A cross-platform Java Native Access (JNA) wrapper for the libusb/hidapi library. Works out of the box on Windows/Mac/Linux.
MIT License
229 stars 71 forks source link

andyrozman changes to HidManager and HidServices, added scanInterval as parameters #40

Closed andyrozman closed 4 years ago

andyrozman commented 8 years ago

This are minor changes to HidManager and HidServices:

See Issue #39

leif81 commented 8 years ago

Lots of whitespace changes. Is it possible to undo those? It's tricky to view the diff with all that noise.

gary-rowe commented 8 years ago

Thanks for this pull request, would you mind reformatting into the style as hid4java (Java Standard with 2 spaces) to assist code review?

gary-rowe commented 7 years ago

@andyrozman Any chance you could update the PR with the latest develop branch and adjust whitespace?

gary-rowe commented 7 years ago

@andyrozman Can we work together on this in the coming weeks to bring in your changes for 0.6.0?

andyrozman commented 7 years ago

@gary-rowe . I am currently on vacation and my computer access is quite limited. I am back on 22, and we can do this then. Do you have perhaps formatting rules you use, so that I could import it into your project on my computer. I use standard 4 spaces formatting, which is probably not the case in your project.

gary-rowe commented 7 years ago

@andyrozman For the hid4java project I use 2 spaces formatting. Happy to wait until you're back and settled to work on it. Enjoy your time off :-)

gary-rowe commented 4 years ago

I'll close this one now given that it's been some time.