Closed jonbanjo closed 4 years ago
Thanks for bringing this to my attention. It may be a while before I can get around to fixing it.
Hi. It's been a long while, but I have managed to get around to this.
Can I verify that your concern with the short
comparison is the unsigned upcast? For example a structure similar to this:
int intVendorId == shortVendorId & 0xFFFF;
Closing as this is essentially a duplicate of #65
You’ve probably got these anyway if you are working on a new version but a couple of observations found while playing with a usb logging multimeter which has a product id of e008.
HidDevice.toString() prepends “ffff” to the product id. HidDevice.isVidPidSerial() does not compare the int parameters with the device short product id correctly.
I’d guess there may be a couple of others where the short representation is negative but the library worked well otherwise for my brief experiment.