search

gary-rowe / hid4java

A cross-platform Java Native Access (JNA) wrapper for the libusb/hidapi library. Works out of the box on Windows/Mac/Linux.
MIT License
229 stars 71 forks source link

Inconsistent method names for adding / removing listener #94

Closed MorpheusUK closed 4 years ago

MorpheusUK commented 4 years ago

Hello,

Firstly thanks for producing this library it has made a project i am working on which is running on an older version of SLE Linux far easier. This is quite a trivial one but I notice that when i add the listener I do a addHidServicesListener(HidServicesListener listener). However to remover the listener the method seems to be unless i have misunderstood its purpose removeUsbServicesListener(HidServicesListener listener).

These should be named consistently.

Thanks

gary-rowe commented 4 years ago

Agreed. I've made the change in the develop branch. Please take a look and let me know if it's OK.

MorpheusUK commented 4 years ago

Yes that's great thanks.

gary-rowe commented 4 years ago

Cool. Closing.