search

garyb / purescript-codec

General purpose bi-directional codecs
MIT License
16 stars 5 forks source link

refactor: type arguments -> make more meaningful #5

Open srghma opened 4 years ago

garyb commented 4 years ago

I'm probably not going to merge this, I don't think naming type variables in very abstract types is useful - even with the names I'd still need to figure it out interactively using holes and such, and as you found, some of the vars don't even have sensible names, or their meaning changes depending on use case.

Mostly these types will be interacted with in a context where the vars are mostly concrete anyway, such as JsonCodec, JPropCodec, etc.

srghma commented 4 years ago

as you found, some of the vars don't even have sensible names

Only in compose methods

Maybe names are not right, but they give at least some context. I dont know how else to resolve this problem.