garyb / purescript-indexed-monad

MIT License
21 stars 11 forks source link

[Old] Provide file for Qualified Do/Ado notation; implements `IxDiscard` #17

Closed JordanMartinez closed 5 years ago

JordanMartinez commented 5 years ago

Fixes #15 Edit: Fixes #18

Part of me wonders whether this should use a different module name than Control.Monad.Indexed because this could also work for ado notation.

Perhaps something like Qualified.Indexed?

garyb commented 5 years ago

Control.Monad.Indexed.Syntax might be another ok name. Hmm 🤔

JordanMartinez commented 5 years ago

Syntax is a bit overreaching though, isn't it? As a user, wouldn't you think that Syntax would include :>>=? Should it?

What about Qualified.Indexed? "Qualified" in that this is qualified do/ado and "Indixed" in that it's the indexed version of the monad class hierarchy.

Or QualifiedNotation.Indexed

garyb commented 5 years ago

Let's just stick with Control.Monad.Indexed.Qualified, it makes as much sense as anything else I think.

IxDiscard looks good too. Are you happy with your changes in here now?

JordanMartinez commented 5 years ago

I've added the preifx '[Old]' to this broken PR. Feel free to merge #19 instead. I'm satisfied with these changes.