search

garyb / purescript-virtual-dom

Low level virtual-dom bindings for PureScript
MIT License
30 stars 7 forks source link

The Meltdown: Migrating to PureScript 0.7 #12

Open jirkamarsik opened 9 years ago

jirkamarsik commented 9 years ago

I wanted to try using virtual-dom from PureScript and I found that this library hasn't been updated for PureScript 0.7, so here is my attempt at doing that.

Since this library does not seem to be used any more, would you know what is currently the preferred way to traverse and manipulate the DOM as an immutable data structure from PureScript?

garyb commented 9 years ago

I haven't given up on this library, just not had time to look at it of late as I've been concentrating on Halogen, which has its own implementation of the virtual-dom functions. I'd like to unify the two at some point, having this as a super simple wrapper around the FFI types.

I'll try and make some time to review this tomorrow.

jirkamarsik commented 9 years ago

Since I made the mkEff commit before reading the FFI documentation on the PureScript website and in the book, I tested it to make sure I understood the correspondence between PureScript types and the JavaScript values. patch was the only function affected and it seems to work.

https://gist.github.com/jirkamarsik/64a64b47ca2d3d4f4ebe

garyb commented 9 years ago

Thanks, sorry I've not been back to this yet. At a glance I think some of the other functions may need updating for the latest virtual-dom: I think thunk, hook and widget may need to be constructed slightly differently now.

dimsuz commented 8 years ago

Hello! What's the fate of this PR? Is it on stall now due to the need of updating of thunk, hook and widget?