garybuhrmaster / tv_grab_zz_sdjson_sqlite

XMLTV grabber for Schedules Direct JSON service
GNU General Public License v2.0
6 stars 8 forks source link

start attribute on previously-shown tag includes timezone #6

Closed mymatenige closed 7 years ago

mymatenige commented 8 years ago

The output of the start attribute on previously-shown tag currently includes the timezone. This is causing MythTV to set the airdate to 0000. For example:

<previously-shown start="20110904 +0000" />

Other xmltv grabbers do not include the timezone. For example with tv_grab_sd_json:

<previously-shown start="20110904" />

See https://sourceforge.net/p/xmltv/mailman/message/35408932/ for more info.

garybuhrmaster commented 7 years ago

As reported in that discussion, the grabber is following the XMLTV specifications correctly. It is the application that is the one in error. And only legacy (no longer supported) versions of MythTV (before commit ff5ab27) have the issue. In order to provide individuals a limited period to upgrade to a currently support variant of their application (they need to work with their upstream developers and/or distro providers) the ability for fixups to be applied for specific application issues via an environment variable has been made available (see fixups.txt in the repo for details).

mymatenige commented 7 years ago

Whilst I don't disagree with your position that it is a client issue, I am still seeing the issue in MythTV 0.28+. There is a clear difference between the handling of the output of your grabber and tv_grab_zz_sdjson. I will perform further investigation.

garybuhrmaster commented 7 years ago

Be sure your fixes/0.28 version includes 841073e