search

garyburgmann / drf-firebase-auth

Firebase backend to receive a user idToken and authenticate via Django REST Framework 'authentication.BaseAuthentication'. Optionally, a new local user can be created in the process.
MIT License
128 stars 62 forks source link

Commit initial database migration #2

Closed jaylynch closed 5 years ago

jaylynch commented 5 years ago

Not sure if it was an intentional decision for trade-offs I'm not aware of, if it is I'm happy to run with a fork.

Most apps seem to come with data migrations committed to package though, and it makes most deployment workflows I'm aware of much cleaner. (Automatically rebuilding is tricky if it needs specific commands at a certain point when a package is added)

Django also seem to assume committing them as default, eg: https://docs.djangoproject.com/en/2.1/topics/migrations/#workflow

garyburgmann commented 5 years ago

There was a reason, re: custom user model, that I went the way I did originally, that is escaping me at this moment. I'll ponder and pull this in on the weekend if I can't remember why, because it is the right thing to do.

garyburgmann commented 5 years ago

There was a reason, re: custom user model, that I went the way I did originally, that is escaping me at this moment. I'll ponder and pull this in on the weekend if I can't remember why, because it is the right thing to do.

The idea was around migration order concerns. But any good developer can just migrate their own User model first before applying migrations for this app.