search

garycourt / uri-js

An RFC 3986 compliant, scheme extendable URI parsing/validating/normalizing/resolving library for JavaScript
Other
305 stars 69 forks source link

4.2.0 breaks .resolve method for URNs #26

Closed epoberezkin closed 6 years ago

epoberezkin commented 6 years ago 
const uri = require('uri-js')
uri.resolve('', 'urn:some:ip:prop'); // 'urn:undefined:undefined'
uri.resolve('#', 'urn:some:ip:prop'); // 'urn:undefined:undefined'
uri.resolve('urn:some:ip:prop', 'urn:some:ip:prop'); // 'urn:undefined:undefined'
epoberezkin commented 6 years ago

came up here: https://github.com/epoberezkin/ajv/pull/751

garycourt commented 6 years ago

Thanks for this! I'll try to get to it soon.

garycourt commented 6 years ago

Should be fixed now!