search

garycourt / uri-js

An RFC 3986 compliant, scheme extendable URI parsing/validating/normalizing/resolving library for JavaScript
Other
305 stars 69 forks source link

Create ES5+Modules dist #32

Open garycourt opened 6 years ago

garycourt commented 6 years ago

In order to support the modules property in package.json, an ES5 version of uri-js using ES6 Modules needs to be compiled.

murphyke commented 6 years ago

There will be much rejoicing. My create-react-app app started failing to build when I added a dependent of uri-js ....

garycourt commented 6 years ago

Use uri-js@^4.2.2 for the time being, as that version doesn't have the modules property in package.json.

murphyke commented 6 years ago

Thanks, I forgot that I had just started using package-lock.json, and I had assumed that my CI/CD build was using the latest version. It's working now, obviously.