search

garycourt / uri-js

An RFC 3986 compliant, scheme extendable URI parsing/validating/normalizing/resolving library for JavaScript
Other
305 stars 69 forks source link

Reduce the size of the npm package by limiting the included files #36

Closed paazmaya closed 4 years ago

paazmaya commented 5 years ago

Looks like the files property (https://docs.npmjs.com/files/package.json#files) is not used in package.json to specify the included files, nor is the .npmignore file (https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package) is being used for blacklisting unwanted files, for the package published to npm.

Would you consider adding either the files property or the .npmignore file, so that the resulting package file would have smaller size?

The current size can be seen when executing the command npm pack (https://docs.npmjs.com/cli/pack).

This issue was create via tawata

bhullarg commented 5 years ago

Created PR#37 (https://github.com/garycourt/uri-js/pull/37) to introduce npmignore

revelt commented 4 years ago

It seems maintainers are not coping well with supporting this package, maybe it would be worth expanding the admin team, to add other maintainers?

garycourt commented 4 years ago

This issue has now been resolved with uri-js@4.3.0.