search

garygrossgarten / rxjs-shortcuts

Keyboard Shortcuts with rxjs
5 stars 7 forks source link

Adding nx? #3

Open joshribakoff opened 4 years ago

joshribakoff commented 4 years ago

If we can add http://Nx.dev we can extract a library that can be used in both react and angular and easily published to npm with rollup producing es6 modules etc.. thoughts?

Or would you be ok with a fork, if you don’t have plans to maintain?

garygrossgarten commented 4 years ago

Hey @joshribakoff what's the benefit of using nx for extracting the library? As this project was built in an angular workspace I could easily release a version using ng-packagr. As long as I'm not using any Angular dependencies it should work everywhere.

I'm planning to add a cheatcode observable in the upcoming week as well. As for forking, feel free to build your own library off of it if you want. I'll probably maintain this one for personal projects.

Cheers

joshribakoff commented 4 years ago

Hey thanks for the reply! Yeah my main intent was to be able to use this logic, whether that means helping get it published, or just determining if the right route would be forking. Feel free to close the issue as you see fit, but it seems potentially valuable to develop into a published package. I’m down to help in whatever way you think is best, although Ill admit I’m more of a react user and not knowledgeable of this packagr tool. I just know we use Nx on RxStore (see my profile) and it lets us cleanly separate example apps, libs, etc.