search

garykac / amhs-robotics-4681

Repository for AMHS's FRC (FIRST Robotics Competition) team
3 stars 0 forks source link

Issues Compilation + Fixes #38

Closed cmarley3-14 closed 5 years ago

cmarley3-14 commented 5 years ago

Issue #32: Sucker extends to grab hatch Issue #37: Update X and Y buttons for Grabber Sucker https://github.com/garykac/amhs-robotics-4681/blob/5d2e7ea2e89d7f81aecccb06fe9dcc977d786f88/workspace/2019%20DeepSpace/src/main/java/frc/robot/Robot.java#L195-L200 https://github.com/garykac/amhs-robotics-4681/blob/5d2e7ea2e89d7f81aecccb06fe9dcc977d786f88/workspace/2019%20DeepSpace/src/main/java/frc/robot/Sucker.java#L20-L31 Pressing X switches between sucking and not sucking modes.
Pressing Y switches between an extended sucker and a retracted sucker.

Issue #33: Rename Walker Front/Back Legs Renaming wasn't necessary. We just had to switch front and back in our climb functions, and we'll need to make sure that our constants file matches the hardware. I.e., check the tubing for front and back, and make sure our initialization port is correct.

Issue #34: Remove Right Grabber Done in Constants.java and Grabber.java. Should be no errors upon building.

Issue #36: Switch for Bottom of Lifter Stephen's code for the switch was finalized.
WARNING: Test with a finger before slamming our heavy grabber on the fragile switch.

Question: Did we test the laser sensor on the non-competition robot to see if it still worked before directly installing it?

Other changes made: The two functions that gave us distance in Lifter have been combined into a single function, which now returns it. The changes were adapted in Robot.java.

In Walker, added a StraightenLegs() function which is used in Robot.java for climbing and restarting climb. Also removed int progress and boolean completed because we aren't using a single Climb() function. Issue #24 should discuss this already.

https://github.com/garykac/amhs-robotics-4681/blob/5d2e7ea2e89d7f81aecccb06fe9dcc977d786f88/workspace/2019%20DeepSpace/src/main/java/frc/robot/Robot.java#L187-L193 https://github.com/garykac/amhs-robotics-4681/blob/5d2e7ea2e89d7f81aecccb06fe9dcc977d786f88/workspace/2019%20DeepSpace/src/main/java/frc/robot/Grabber.java#L28-L42 Holding (not pressing) A will grab, while holding B will eject. Not holding either will stop the grabber intake motors.

cmarley3-14 commented 5 years ago

We'll merge and deploy tomorrow morning.
The branch was created to keep track of all the changes. Nothing's wrong.