garywill / linux-router

Set Linux as router in one command. Support Internet sharing, redsocks, Wifi hotspot, IPv6. Can also be used for routing VM/containers 🛰️
GNU Lesser General Public License v2.1
1.73k stars 153 forks source link

Should allow `brmfmac` driver without `--no-virt` #71

Open keogami opened 7 months ago

keogami commented 7 months ago

While trying to run linux-router on a Raspberry pi 5 with a stock Raspberry pi OS (x64) I received the following error:

> lnxrouter --ap wlan0 ssid -p passphrase
WARN: brmfmac driver doesn't work properly with virtual interfaces and
      it can cause kernel panic. For this reason we disallow virtual
      interfaces for your adapter.
      For more info: https://github.com/oblique/create_ap/issues/203

Going through the issue its clear they tested a long while ago, so I wagered that the bug in the driver is probably fixed by now.

So I patched lnxrouter to run even with brmfmac and it seems to be running fine, with no relevant issues.

I don't have conclusive evidence that the issue has been fixed from the root, but I suggest it is worth investigating.