garyzhao / SemGCN

The Pytorch implementation for "Semantic Graph Convolutional Networks for 3D Human Pose Regression" (CVPR 2019).
https://arxiv.org/abs/1904.03345
Apache License 2.0
460 stars 78 forks source link

A #19

Open haolianxinyi opened 4 years ago

haolianxinyi commented 4 years ago

Hi, in my reproduce work, there is a mistake which I don't know how to solve. models/sem_gcn.py", line 49 self.nonlocal = GraphNonLocal(hid_dim, sub_sample=group_size) ^ SyntaxError: invalid syntax

garyzhao commented 4 years ago

Hi, in my reproduce work, there is a mistake which I don't know how to solve. models/sem_gcn.py", line 49 self.nonlocal = GraphNonLocal(hid_dim, sub_sample=group_size) ^ SyntaxError: invalid syntax

Hi @haolianxinyi ,

It seems a syntax error. Please check if you have incorrect indent or missing parentheses.

Best, Long

haolianxinyi commented 4 years ago

Thank you very much, the problem is handled.

LawrenceXu13467 commented 4 years ago

nonlocal is identified as a python keyword here. Maybe it's better to change it to something else?

garyzhao commented 4 years ago

nonlocal is identified as a python keyword here. Maybe it's better to change it to something else?

Hi @LawrenceXu13467 ,

Thanks for pointing it out.

nonlocal is a keyword introduced in Python 3. This repo is developed with Python 2 by default, so it should not be a problem. But if you are upgrading to Python 3, it will be better to change it.

Best, Long

jellyfish1456 commented 3 years ago

@garyzhao Hi there~

My python version is: 3.6.10 and I retype the function here. However is still not working....

jellyfish1456 commented 3 years ago

it seems that it is nonLocal keywords problem.